maximus/Simpl-Resultat

Fork 0

feat(prices): Settings revocation toggle for price_fetching_consent (#159) #168

Merged

maximus merged 3 commits from issue-159-settings-revoke-toggle into main

2026-04-28 01:36:15 +00:00

maximus commented

2026-04-27 12:41:26 +00:00

Owner

Summary

New PriceFetchConsentToggle component in src/components/settings/
Wired into SettingsPage.tsx Privacy section
Reads/writes user_preferences.price_fetching_consent for active profile
Confirmation dialog before revoke (DELETE the row entirely so next click on PriceFetchControl re-opens consent modal)
Disabled when license is not premium (tooltip via notPremium key)
Adds deletePreference() to userPreferenceService
Adds settings.privacy.title i18n key (FR + EN)
10 vitest tests covering all paths

Stacked on (must merge first)

This branch contains a merge from upstream autopilot PRs:

#167 (transitively #163, #164, #166)

Closes #159

Generated autonomously by /autopilot run of 2026-04-27

## Summary - New `PriceFetchConsentToggle` component in `src/components/settings/` - Wired into `SettingsPage.tsx` Privacy section - Reads/writes `user_preferences.price_fetching_consent` for active profile - Confirmation dialog before revoke (DELETE the row entirely so next click on `PriceFetchControl` re-opens consent modal) - Disabled when license is not premium (tooltip via `notPremium` key) - Adds `deletePreference()` to `userPreferenceService` - Adds `settings.privacy.title` i18n key (FR + EN) - 10 vitest tests covering all paths ## Stacked on (must merge first) This branch contains a merge from upstream autopilot PRs: - #167 (transitively #163, #164, #166) Closes #159 Generated autonomously by /autopilot run of 2026-04-27

maximus added 9 commits 2026-04-27 12:41:28 +00:00

feat(prices): i18n FR/EN keys + CHANGELOG entries

PR Check / rust (push) Successful in 26m25s

Details

PR Check / frontend (push) Successful in 2m34s

Details

PR Check / rust (pull_request) Successful in 26m20s

Details

PR Check / frontend (pull_request) Successful in 2m54s

Details

ab7e0a3362

Closes #160

feat(prices): useIsPremium hook from license.edition

PR Check / rust (push) Successful in 26m18s

Details

PR Check / frontend (push) Successful in 2m37s

Details

PR Check / rust (pull_request) Successful in 25m0s

Details

PR Check / frontend (pull_request) Successful in 2m41s

Details

98f68f7a1f

- Reads useLicense().state.edition === 'premium'
- Ergonomic only — server enforces independently (ADR 0011)
- 3 vitest tests (premium, base, free)
- CLAUDE.md hook count 12 -> 13

Closes #157

feat(prices): balance.service prices section with rate-limit + dedup + retries

PR Check / rust (push) Successful in 27m27s

Details

PR Check / frontend (push) Successful in 2m49s

Details

PR Check / rust (pull_request) Successful in 28m58s

Details

PR Check / frontend (pull_request) Successful in 2m57s

Details

920f81fce5

- prices.fetchPrice wraps invoke('fetch_price', ...) with local rate-limit (1/2s), in-flight dedup, exp backoff on 5xx (2/4/8s, max 3 retries), no retry on 4xx/429, hard 100/session cap
- 9 vitest tests with vi.useFakeTimers() (happy, 401/403/404, 429 no-retry, 5xx retries, dedup, pacing, session cap)
- Annexe B i18n mapping wired (PriceError → balance.priceFetching.errors.* keys)
- Session cap checked before rate-limit/dedup; failures do not consume budget (MEDIUM decision)

Closes #156

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

merge: bring in i18n keys from #160 b1dc76b487

merge: bring in useIsPremium hook from #157 99814b9a0d

merge: bring in balance.service prices namespace from #156 c90badae39

feat(prices): PriceFetchControl component + consent modal + best-effort UX

PR Check / rust (push) Successful in 30m45s

Details

PR Check / frontend (push) Successful in 3m12s

Details

PR Check / rust (pull_request) Successful in 28m50s

Details

PR Check / frontend (pull_request) Successful in 3m15s

Details

043e9bf622

- New component renders button + consent modal + spinner + attribution
- Best-effort warning shown once per session for stock categories
- Hidden if not premium or category kind != 'priced'
- Consent persisted per-profile in user_preferences.price_fetching_consent
- Manual unit_price input remains active in all paths
- 17 vitest tests (no RTL/jsdom — logged MEDIUM in decisions-log.md)
- Wired into SnapshotLineRow/SnapshotEditor/SnapshotEditPage
- asset_type hardcoded to 'stock' pending category schema extension (MEDIUM)

Closes #158

merge: bring in #158 (transitively #156/#157/#160) 8fa34d786d

feat(prices): Settings revocation toggle for price_fetching_consent

PR Check / rust (push) Successful in 28m16s

Details

PR Check / frontend (push) Successful in 3m0s

Details

PR Check / rust (pull_request) Successful in 29m45s

Details

PR Check / frontend (pull_request) Successful in 3m6s

Details

80c28d43ac

- Adds PriceFetchConsentToggle to SettingsPage Privacy section
- Reads/writes user_preferences.price_fetching_consent for active profile
- Confirmation dialog before revoke (DELETE the key entirely so next click re-opens consent modal)
- Disabled (with notPremium tooltip) when license is not premium
- Adds deletePreference() to userPreferenceService
- Adds settings.privacy.title i18n key (FR + EN)
- 10 vitest tests covering all paths

Closes #159