maximus/Simpl-Resultat
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases 23 Packages Wiki Activity Actions

feat(prices): balance.service prices section + rate-limit + tests #156

New issue
Closed
opened 2026-04-27 00:15:36 +00:00 by maximus · 0 comments
maximus commented 2026-04-27 00:15:36 +00:00
Owner
Copy link

Goal

Extend src/services/balance.service.ts with a prices section that wraps the fetch_price Tauri command with rate-limiting, dedup, and a hard session cap.

Contract reference

docs/api-contract-prices.md §6.2 (client rate-limit), §12.1 (tests), Annexe B (i18n mapping).

Fichiers concernés

  • src/services/balance.service.ts (add prices section, ~150 lines new)
  • src/services/balance.service.test.ts (add new test suite, ~200 lines new)

Depends on

Scope

  • In balance.service.ts, add namespace export prices:
    • prices.fetchPrice(symbol: string, date: string): Promise<PriceResult> — calls invoke('fetch_price', {...})
    • Maps Rust FetchPriceError (string discriminant) to TS discriminated union PriceError
    • Mapping PriceError → balance.priceFetching.errors.<key> per Annexe B
  • Rate-limit local : pace outgoing requests at max 1 / 2 sec. Subsequent calls queue. Implementation: simple lastFiredAt timestamp + setTimeout for delay.
  • Dedup in-flight : a Map<string, Promise<PriceResult>> keyed by ${symbol}|${date}. Calls during in-flight return the same promise.
  • Backoff exponentiel sur 5xx / network / provider_unavailable : 2s, 4s, 8s. Max 3 retries. Pas de retry sur 429 (cf. décision ce soir) — surface immédiat à l'UI.
  • Pas de retry sur 401, 403, 404, 400 — surface immédiat.
  • Plafond hard 100 req / session. « Session » = lifetime of the Tauri app process. Counter resets on app restart (in-memory). 101e appel rejette avec PriceError.SessionCapReached.
  • Vitest tests with vi.useFakeTimers() :
    • happy path 200
    • 401/403/404/400 → no retry
    • 5xx → 3 retries with 2/4/8s delays, then fail
    • 429 → no retry, surface immediately with retry_after
    • dedup : two await prices.fetchPrice('AAPL', '2026-04-25') in parallel → 1 underlying invoke call
    • rate-limit pacing : 3 calls in 1ms → 1st now, 2nd at +2s, 3rd at +4s
    • session cap : 100 successful calls OK, 101e rejette

Critères d'acceptation

  • npm test src/services/balance.service.test.ts green (≥ 8 tests on prices section)
  • Toutes les tests temporelles utilisent vi.useFakeTimers() — non flaky
  • Pas d'import de lib externe (msw, nock) — uniquement vi.fn() sur invoke
  • TypeScript strict mode clean (tsc --noEmit)

Décisions prises ce soir

  • 429 = surface immédiate, pas de retry auto. Toast UI avec retry_after.
  • « Session » = app process lifetime. Pas de persistance, pas de reset sur profile switch.
  • Lib mock : vi.fn() natif sur invoke (pas de msw).

Spec source

docs/api-contract-prices.md

## Goal Extend `src/services/balance.service.ts` with a `prices` section that wraps the `fetch_price` Tauri command with rate-limiting, dedup, and a hard session cap. ## Contract reference `docs/api-contract-prices.md` §6.2 (client rate-limit), §12.1 (tests), Annexe B (i18n mapping). ## Fichiers concernés - `src/services/balance.service.ts` (add `prices` section, ~150 lines new) - `src/services/balance.service.test.ts` (add new test suite, ~200 lines new) ## Depends on - #154, #155 ## Scope - [ ] In `balance.service.ts`, add namespace export `prices`: - `prices.fetchPrice(symbol: string, date: string): Promise<PriceResult>` — calls `invoke('fetch_price', {...})` - Maps Rust `FetchPriceError` (string discriminant) to TS discriminated union `PriceError` - Mapping `PriceError → balance.priceFetching.errors.<key>` per Annexe B - [ ] **Rate-limit local** : pace outgoing requests at max 1 / 2 sec. Subsequent calls queue. Implementation: simple `lastFiredAt` timestamp + `setTimeout` for delay. - [ ] **Dedup in-flight** : a `Map<string, Promise<PriceResult>>` keyed by `${symbol}|${date}`. Calls during in-flight return the same promise. - [ ] **Backoff exponentiel** sur 5xx / network / `provider_unavailable` : 2s, 4s, 8s. Max 3 retries. **Pas de retry sur 429** (cf. décision ce soir) — surface immédiat à l'UI. - [ ] **Pas de retry sur 401, 403, 404, 400** — surface immédiat. - [ ] **Plafond hard 100 req / session**. « Session » = lifetime of the Tauri app process. Counter resets on app restart (in-memory). 101e appel rejette avec `PriceError.SessionCapReached`. - [ ] Vitest tests with `vi.useFakeTimers()` : - happy path 200 - 401/403/404/400 → no retry - 5xx → 3 retries with 2/4/8s delays, then fail - 429 → no retry, surface immediately with `retry_after` - dedup : two `await prices.fetchPrice('AAPL', '2026-04-25')` in parallel → 1 underlying invoke call - rate-limit pacing : 3 calls in 1ms → 1st now, 2nd at +2s, 3rd at +4s - session cap : 100 successful calls OK, 101e rejette ## Critères d'acceptation - [ ] `npm test src/services/balance.service.test.ts` green (≥ 8 tests on `prices` section) - [ ] Toutes les tests temporelles utilisent `vi.useFakeTimers()` — non flaky - [ ] Pas d'import de lib externe (`msw`, `nock`) — uniquement `vi.fn()` sur `invoke` - [ ] TypeScript strict mode clean (`tsc --noEmit`) ## Décisions prises ce soir - 429 = surface immédiate, pas de retry auto. Toast UI avec `retry_after`. - « Session » = app process lifetime. Pas de persistance, pas de reset sur profile switch. - Lib mock : `vi.fn()` natif sur `invoke` (pas de `msw`). ## Spec source `docs/api-contract-prices.md`
maximus added this to the spec-price-fetching milestone 2026-04-27 00:15:36 +00:00
maximus added the
status:ready
type:feature
source:human
 labels 2026-04-27 00:15:36 +00:00
maximus modified the milestone from spec-price-fetching to overnight-2026-04-27-prices 2026-04-27 00:32:02 +00:00
maximus added the
status:in-progress
 label 2026-04-27 12:28:44 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
issue-187-balance-cleanup-post-184-185
issue-188-webkit-date-picker-7-inputs
issue-180-postcss-audit-fix
issue-190-restructure-settings-pages
issue-161-smoke-scaffold
issue-171-ci-drop-push-trigger
issue-169-asset-type-balance-categories
issue-67-feedback-widget
issue-97-cartes-page
issue-96-compare-refactor
issue-51-compte-maximus-oauth
issue-46-license-commands-entitlements
issue-48-gate-auto-updates
issue-47-license-ui-card
fix/simpl-resultat-54-argon2id-pin
fix/simpl-resultat-59-bump-vite
issue-43-update-picomatch
fix/simpl-resultat-41-category-time-report-filter
fix/simpl-resultat-31-dashboard-month-dropdown
fix/simpl-resultat-29-budget-visual-adjustments
fix/simpl-resultat-23-dashboard-category-ordering
fix/simpl-resultat-16-prev-year-budget
fix/simpl-resultat-19-tooltip-transparency
fix/simpl-resultat-17-remove-piechart-title
fix/simpl-resultat-16-budget-previous-year
v0.9.1
v0.9.0
v0.8.4
v0.8.3
v0.8.2
v0.8.1
v0.8.0
v0.7.4
v0.7.3
v0.7.2
v0.7.1
v0.7.0
v0.6.7
v0.6.6
v0.6.5
v0.6.4
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.2
v0.5.0
v0.4.2
v0.4.0
v0.3.11
v0.3.10
v0.3.9
v0.3.8
v0.3.7
v0.3.6
v0.3.5
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.12
v0.2.11
v0.2.10
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.2
v0.1.1
v0.1.0
Labels
Clear labels   
autopilot:pending-human

PR produced by /autopilot — awaits human review/merge

  
source:analyste

Créée par le Super-Analyste

  
source:defenseur

Créée par l Escouade Défenseur

  
source:human

Créée par un humain

  
source:medic

Créée par le Medic (auto-détection)

  
status:approved

PR approuvée, prête à merger

  
status:blocked

Bloquée (question, dépendance, clarification)

  
status:in-progress

Un agent (Medic/Dev) travaille dessus

  
status:needs-clarification

Issue blocked by ambiguity — Max needs to clarify before re-running autopilot

  
status:needs-fix

Reviewer demande des corrections

  
status:ready

Analysée et documentée, prête à prendre

  
status:review

PR créée, en attente du Reviewer

  
status:triage

Nouvelle issue, pas encore analysée

  
type:bug

Correction de bug → Medic

  
type:feature

Nouvelle fonctionnalité → Dev

  
type:infra

Config, CI/CD, déploiement → Dev

  
type:refactor

Refactoring / amélioration technique → Dev

  
type:schema

Modèle de données / migrations → Dev

  
type:security

Issue de sécurité → Medic ou Dev

No labels
autopilot:pending-human
source:analyste
source:defenseur
source:human
source:medic
status:approved
status:blocked
status:in-progress
status:needs-clarification
status:needs-fix
status:ready
status:review
status:triage
type:bug
type:feature
type:infra
type:refactor
type:schema
type:security
Milestone
Clear milestone
No items
No milestone
overnight-2026-04-27-prices
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: maximus/Simpl-Resultat#156
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?