maximus/Simpl-Resultat

Fork 0

feat(prices): PriceFetchControl + consent modal + best-effort UX (#158) #167

Merged

maximus merged 7 commits from issue-158-pricefetchcontrol into main

2026-04-28 01:35:24 +00:00

maximus commented

2026-04-27 12:36:40 +00:00

Owner

Summary

New PriceFetchControl.tsx component with button + consent modal + spinner + attribution + best-effort warning (stock only)
Hidden if useIsPremium() === false or categoryKind !== 'priced'
Consent persisted per-profile in user_preferences.price_fetching_consent ({consented_at, version: 1} shape)
Best-effort warning shown once per session (in-memory dismiss via module-level _bestEffortDismissedThisSession)
Manual unit_price input remains active in all error paths
Wired into SnapshotLineRow → SnapshotEditor → SnapshotEditPage next to priced-line inputs
17 vitest tests (all passing)

Decisions

MEDIUM: No @testing-library/react or jsdom — tests are pure unit tests of logic/mocks, not DOM rendering (logged in decisions-log.md)
MEDIUM: asset_type not in balance_categories schema — defaulting to 'stock' with // TODO comment (follow-up needed)
LOW: user_preferences is per-profile by architecture (separate SQLite DB per profile), no profile_id needed in key

Stacked on (must merge first)

This branch contains merges from upstream autopilot PRs that have not yet landed:

#163 (issue-160-i18n-changelog)
#164 (issue-157-use-is-premium)
#166 (issue-156-balance-service-prices)

After those land, this PR will rebase down to only the PriceFetchControl-specific changes.

Closes #158

Generated autonomously by /autopilot run of 2026-04-27

## Summary - New `PriceFetchControl.tsx` component with button + consent modal + spinner + attribution + best-effort warning (stock only) - Hidden if `useIsPremium() === false` or `categoryKind !== 'priced'` - Consent persisted per-profile in `user_preferences.price_fetching_consent` (`{consented_at, version: 1}` shape) - Best-effort warning shown once per session (in-memory dismiss via module-level `_bestEffortDismissedThisSession`) - Manual unit_price input remains active in all error paths - Wired into SnapshotLineRow → SnapshotEditor → SnapshotEditPage next to priced-line inputs - 17 vitest tests (all passing) ## Decisions - **MEDIUM**: No `@testing-library/react` or jsdom — tests are pure unit tests of logic/mocks, not DOM rendering (logged in `decisions-log.md`) - **MEDIUM**: `asset_type` not in `balance_categories` schema — defaulting to `'stock'` with `// TODO` comment (follow-up needed) - **LOW**: `user_preferences` is per-profile by architecture (separate SQLite DB per profile), no `profile_id` needed in key ## Stacked on (must merge first) This branch contains merges from upstream autopilot PRs that have not yet landed: - #163 (issue-160-i18n-changelog) - #164 (issue-157-use-is-premium) - #166 (issue-156-balance-service-prices) After those land, this PR will rebase down to only the PriceFetchControl-specific changes. Closes #158 Generated autonomously by /autopilot run of 2026-04-27

maximus added 7 commits 2026-04-27 12:36:41 +00:00

feat(prices): i18n FR/EN keys + CHANGELOG entries

PR Check / rust (push) Successful in 26m25s

Details

PR Check / frontend (push) Successful in 2m34s

Details

PR Check / rust (pull_request) Successful in 26m20s

Details

PR Check / frontend (pull_request) Successful in 2m54s

Details

ab7e0a3362

Closes #160

feat(prices): useIsPremium hook from license.edition

PR Check / rust (push) Successful in 26m18s

Details

PR Check / frontend (push) Successful in 2m37s

Details

PR Check / rust (pull_request) Successful in 25m0s

Details

PR Check / frontend (pull_request) Successful in 2m41s

Details

98f68f7a1f

- Reads useLicense().state.edition === 'premium'
- Ergonomic only — server enforces independently (ADR 0011)
- 3 vitest tests (premium, base, free)
- CLAUDE.md hook count 12 -> 13

Closes #157

feat(prices): balance.service prices section with rate-limit + dedup + retries

PR Check / rust (push) Successful in 27m27s

Details

PR Check / frontend (push) Successful in 2m49s

Details

PR Check / rust (pull_request) Successful in 28m58s

Details

PR Check / frontend (pull_request) Successful in 2m57s

Details

920f81fce5

- prices.fetchPrice wraps invoke('fetch_price', ...) with local rate-limit (1/2s), in-flight dedup, exp backoff on 5xx (2/4/8s, max 3 retries), no retry on 4xx/429, hard 100/session cap
- 9 vitest tests with vi.useFakeTimers() (happy, 401/403/404, 429 no-retry, 5xx retries, dedup, pacing, session cap)
- Annexe B i18n mapping wired (PriceError → balance.priceFetching.errors.* keys)
- Session cap checked before rate-limit/dedup; failures do not consume budget (MEDIUM decision)

Closes #156

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

merge: bring in i18n keys from #160 b1dc76b487

merge: bring in useIsPremium hook from #157 99814b9a0d

merge: bring in balance.service prices namespace from #156 c90badae39

feat(prices): PriceFetchControl component + consent modal + best-effort UX

PR Check / rust (push) Successful in 30m45s

Details

PR Check / frontend (push) Successful in 3m12s

Details

PR Check / rust (pull_request) Successful in 28m50s

Details

PR Check / frontend (pull_request) Successful in 3m15s

Details

043e9bf622

- New component renders button + consent modal + spinner + attribution
- Best-effort warning shown once per session for stock categories
- Hidden if not premium or category kind != 'priced'
- Consent persisted per-profile in user_preferences.price_fetching_consent
- Manual unit_price input remains active in all paths
- 17 vitest tests (no RTL/jsdom — logged MEDIUM in decisions-log.md)
- Wired into SnapshotLineRow/SnapshotEditor/SnapshotEditPage
- asset_type hardcoded to 'stock' pending category schema extension (MEDIUM)

Closes #158