fix: onboarding feedback follow-ups: root files warning, pins, help texts, docs (#446) #475

Open
maximus wants to merge 5 commits from issue-446-review-followups into issue-384-onboarding-followups

5 commits

Author SHA1 Message Date
le king fu
08e6f045ae test: read the banner's dots once in the presence test (#446)
All checks were successful
PR Check — Frontend / frontend (pull_request) Successful in 2m2s
Self-review tidy-up: the presence test looked the dots up twice; it now
keeps the one list it asserts on. No assertion changed.

Resolves #446

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 21:07:44 -04:00
le king fu
52e005ef92 docs: components recounted, five report cards, Ctrl+click on Trends (#446)
All checks were successful
PR Check — Frontend / frontend (pull_request) Successful in 2m2s
architecture.md: 138 components, counted as the .tsx files of
src/components outside tests (find src/components -name '*.tsx'
! -name '*.test.tsx' | wc -l), was 61; per domain, balance 12 with its
actual names (BalanceOnboardingCard is gone), categories 8, reports 35,
and the missing categories-migration/ line (5). The /reports hub has 5
navigation cards, named. The useImportWizard row says SET_IMPORT_FOLDER
empties rootFiles and keeps the scanned sources until the next scan.
"La mise en évidence" notes that a Ctrl+click on the Trends card fires
onClick, so it checks the "Browse the reports" step while the router
does not navigate; judged theoretical without tabs in the webview.

CLAUDE.md: 138 components (was 53), import 18 (was 14).

CHANGELOG (EN, FR): Changed for the help texts, Fixed for the root
files warning after choosing another import folder.

Resolves #446

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 21:04:46 -04:00
le king fu
d068c7ecbb fix(i18n): name the reports by their cards, and how the visit steps get checked (#446)
reports.help.tips[2] and [3] named "Monthly Trends" and "Category Over
Time" ("Tendances mensuelles", "Catégories dans le temps"), tabs that
no longer exist: they now name the Trends and Category Analysis cards
of the hub. docs.dashboard.features[6] said the eight steps tick
themselves from the data; the two visit steps are checked with "Got it".
French texts as validated by Max on 2026-10-16, English aligned; the
guide's line of the dashboard features follows docs.dashboard.features.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 20:59:22 -04:00
le king fu
d551c4b0d4 test: pin the collapsed sub-group order and the banner's dot (#446)
reorderRows: a collapsed sub-group (a subtotal with no child row)
followed by a sibling leaf gives Vide, z, A, the order read by running
the case first; then the same block followed by a sibling root, a group
(Vide, z, A, b, B) or a leaf (Vide, z, A, R).

OnboardingBanner: the decorative h-1 w-1 dot is absent while the visit
steps are not initialized and while the Budget entitlement is unknown,
and present, between the counter and the next step, once the total is
known.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 20:59:17 -04:00
le king fu
a62150d926 fix(import): empty the root files when another import folder is chosen (#446)
SET_IMPORT_FOLDER now empties rootFiles. Until the new folder's scan
landed, or for good when that scan failed, the warning about files
placed directly in the import folder named the previous folder's files
under the new folder's name. scannedSources is left as it was: the
source list of the last scan stays until the new one, as before.

Reducer tests next to "a scan error leaves the root files of the last
scan in place": a folder change empties the root files and keeps the
sources until the next scan, and a scan error after a folder change
names no root file of the previous folder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-18 20:59:13 -04:00