feat(reports): adopt shared FilterPanel on Compare and Budget #284

Closed

maximus wants to merge 1 commit from issue-276-adopt-compare-budget into issue-275-adopt-trends

Author	SHA1	Message	Date
le king fu	fe9ae0118c	feat(reports): adopt shared FilterPanel on Compare and Budget Mounts <FilterPanel> on ReportsComparePage (next to the existing CompareReferenceMonthPicker) and BudgetPage (next to the existing YearNavigator), keeping each page's temporal control unchanged. Threads accountIds from useReportsPeriod through useCompare into getCompareMonthOverMonth/getCompareYearOverYear, and through CompareBudgetView into getBudgetVsActualData — closing the gap where that sub-tab silently ignored the filter while the rest of the Compare page respected it. Budget: the issue named getBudgetVsActualData as the target for useBudget, but that hook never calls it (it's exclusive to CompareBudgetView/Dashboard/Cartes) — its only real actuals fetch is getActualTotalsForYear(year - 1), the previous-year reference column. Extended that function with the same optional accountIds pass-through established by #273, rather than wiring in an unrelated call shape. Both hooks fetch their account checkbox list via getAllImportSources, mirroring the useTrends/#275 pattern. Empty selection = no filter, byte-identical to pre-#276 output (regression-tested). Resolves #276 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 15:52:21 -04:00

Author

SHA1

Message

Date

le king fu

fe9ae0118c

feat(reports): adopt shared FilterPanel on Compare and Budget

Mounts <FilterPanel> on ReportsComparePage (next to the existing
CompareReferenceMonthPicker) and BudgetPage (next to the existing
YearNavigator), keeping each page's temporal control unchanged. Threads
accountIds from useReportsPeriod through useCompare into
getCompareMonthOverMonth/getCompareYearOverYear, and through
CompareBudgetView into getBudgetVsActualData — closing the gap where
that sub-tab silently ignored the filter while the rest of the Compare
page respected it.

Budget: the issue named getBudgetVsActualData as the target for
useBudget, but that hook never calls it (it's exclusive to
CompareBudgetView/Dashboard/Cartes) — its only real actuals fetch is
getActualTotalsForYear(year - 1), the previous-year reference column.
Extended that function with the same optional accountIds pass-through
established by #273, rather than wiring in an unrelated call shape.

Both hooks fetch their account checkbox list via getAllImportSources,
mirroring the useTrends/#275 pattern. Empty selection = no filter,
byte-identical to pre-#276 output (regression-tested).

Resolves #276

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-11 15:52:21 -04:00