fix(balance): scope v16 abort guard to convertible accounts (#228) #229

Open

maximus wants to merge 1 commit from issue-228-v16-guard-convertible-scope into main

Author	SHA1	Message	Date
le king fu	cf3e06c910	fix(balance): scope v16 abort guard to convertible accounts (#228 ) All checks were successful PR Check / rust (pull_request) Successful in 23m8s Details PR Check / frontend (pull_request) Successful in 2m29s Details The v16 belt-and-suspenders abort guard keyed on `a.symbol IS NOT NULL` instead of convertibility. A simple-category account carrying a residual symbol (left by a priced→simple recategorization; AccountForm renders the symbol field unconditionally) has quantity-NULL lines by construction; they satisfied the over-broad predicate, so the guard inserted 0, the CHECK(ok = 1) failed, and the whole v16 migration aborted — the app no longer started for that profile. JOIN balance_categories and require `c.asset_type IS NOT NULL` in the guard subquery, in all three copies (Migration v16, V16_SQL mirror, and the V16_CORRUPT injected-failure test, kept statement-equivalent). Add a regression test seeding a simple account with a residual symbol plus a quantity-NULL line: v16 now applies without abort and leaves the account intact (not converted, no security/holding, qty/value preserved). Modifying v16 in place is safe: it has never shipped in a tagged release (v0.9.1 stopped at v13; v14-v16 are unreleased), so no persisted profile carries its checksum yet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-09 21:31:34 -04:00

Author

SHA1

Message

Date

le king fu

cf3e06c910

fix(balance): scope v16 abort guard to convertible accounts (#228 )

PR Check / rust (pull_request) Successful in 23m8s

Details

PR Check / frontend (pull_request) Successful in 2m29s

Details

The v16 belt-and-suspenders abort guard keyed on `a.symbol IS NOT NULL`
instead of convertibility. A simple-category account carrying a residual
symbol (left by a priced→simple recategorization; AccountForm renders the
symbol field unconditionally) has quantity-NULL lines by construction;
they satisfied the over-broad predicate, so the guard inserted 0, the
CHECK(ok = 1) failed, and the whole v16 migration aborted — the app no
longer started for that profile.

JOIN balance_categories and require `c.asset_type IS NOT NULL` in the guard
subquery, in all three copies (Migration v16, V16_SQL mirror, and the
V16_CORRUPT injected-failure test, kept statement-equivalent). Add a
regression test seeding a simple account with a residual symbol plus a
quantity-NULL line: v16 now applies without abort and leaves the account
intact (not converted, no security/holding, qty/value preserved).

Modifying v16 in place is safe: it has never shipped in a tagged release
(v0.9.1 stopped at v13; v14-v16 are unreleased), so no persisted profile
carries its checksum yet.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-09 21:31:34 -04:00