feat(balance): starter accounts + opt-in modal + ADR 0012 (#179) #185

Closed

maximus wants to merge 1 commit from issue-179-starter-accounts into issue-178-onboarding-card

Author	SHA1	Message	Date
le king fu	cd0a2b826f	feat(balance): starter accounts + opt-in modal + ADR 0012 Part 1 — New profiles: seed 4 starter accounts in consolidated_schema.sql (Compte chèque/CELI/REER/Compte non-enregistré, currency CAD, is_active=1) right after the balance_categories seeds. Categories resolved via SELECT subquery on the seeded `key` values for robustness. Part 2 — Existing profiles: StarterAccountsModal proposes the same 4 starters at first /balance visit. Default-checked checkboxes, collision rule (case-insensitive trim name + matching category) disables matches with a "Déjà présent" tooltip. The atomic helper `proposeStarterAccounts` wraps the inserts in BEGIN/COMMIT (rolls back on error). user_preferences.balance_starter_proposed records {shown_at, accepted} so the modal never reappears, dismissed or confirmed. Part 3 — docs/adr/0012-balance-two-level-model.md (Proposed): captures the future vehicles × compositions model for reflection, no code change. Numbered 0012 because 0011 was already taken by the providers-best-effort-yahoo ADR. Linked from architecture.md ADR table and Bilan section. Tests: StarterAccountsModal.test.tsx covers STARTER_ACCOUNTS shape, getStarterCollisions (case-insensitive trim, category-scoped) and proposeStarterAccounts (insert order, COMMIT, ROLLBACK on failure). No render tests — mirrors the BalanceOnboardingCard pattern (no jsdom configured). Resolves #179	2026-05-02 11:59:45 -04:00

Author

SHA1

Message

Date

le king fu

cd0a2b826f

feat(balance): starter accounts + opt-in modal + ADR 0012

Part 1 — New profiles: seed 4 starter accounts in
consolidated_schema.sql (Compte chèque/CELI/REER/Compte
non-enregistré, currency CAD, is_active=1) right after the
balance_categories seeds. Categories resolved via SELECT subquery
on the seeded `key` values for robustness.

Part 2 — Existing profiles: StarterAccountsModal proposes the same
4 starters at first /balance visit. Default-checked checkboxes,
collision rule (case-insensitive trim name + matching category)
disables matches with a "Déjà présent" tooltip. The atomic helper
`proposeStarterAccounts` wraps the inserts in BEGIN/COMMIT (rolls
back on error). user_preferences.balance_starter_proposed records
{shown_at, accepted} so the modal never reappears, dismissed or
confirmed.

Part 3 — docs/adr/0012-balance-two-level-model.md (Proposed):
captures the future vehicles × compositions model for reflection,
no code change. Numbered 0012 because 0011 was already taken by
the providers-best-effort-yahoo ADR. Linked from architecture.md
ADR table and Bilan section.

Tests: StarterAccountsModal.test.tsx covers STARTER_ACCOUNTS shape,
getStarterCollisions (case-insensitive trim, category-scoped) and
proposeStarterAccounts (insert order, COMMIT, ROLLBACK on failure).
No render tests — mirrors the BalanceOnboardingCard pattern (no
jsdom configured).

Resolves #179

2026-05-02 11:59:45 -04:00