test(balance): cross-cutting integration tests (#144) #152

Merged

maximus merged 4 commits from issue-144-bilan-6 into main

2026-04-26 13:25:38 +00:00

maximus commented

2026-04-25 20:54:53 +00:00

Owner

Closes #144

Stacked on top of #151 (Issue #142). Base: issue-142-bilan-4. Will need rebase once upstream PRs merge.

Summary

E2E vitest flow (mock Tauri) covering account → priced category → snapshot → transfer → return
Currency lock test (currency != CAD rejected by service + SQL CHECK)
Rust integration: migration v9 on seeded DB + FK transfer link/unlink
TransactionsPage non-regression for transfer icon inlining
Coverage best-effort on return_calculator.rs (80%) and balance.service.ts (70%)
CHANGELOG entries (FR + EN) under [Unreleased]

Test plan

cargo check / cargo test
npm run build / npm test
Manual verification — pending human

Generated autonomously by /autopilot run of 2026-04-25

Closes #144 > Stacked on top of #151 (Issue #142). Base: issue-142-bilan-4. Will need rebase once upstream PRs merge. ## Summary - E2E vitest flow (mock Tauri) covering account → priced category → snapshot → transfer → return - Currency lock test (currency != CAD rejected by service + SQL CHECK) - Rust integration: migration v9 on seeded DB + FK transfer link/unlink - TransactionsPage non-regression for transfer icon inlining - Coverage best-effort on return_calculator.rs (80%) and balance.service.ts (70%) - CHANGELOG entries (FR + EN) under [Unreleased] ## Test plan - [x] cargo check / cargo test - [x] npm run build / npm test - [ ] Manual verification — pending human Generated autonomously by /autopilot run of 2026-04-25

maximus added 4 commits 2026-04-25 20:54:54 +00:00

test(balance): add cross-cutting integration tests 9adfb85d84

End-to-end happy path through the full Bilan stack: account → priced
category → priced snapshot → linked transfer → return. Drives every
service against the existing in-memory FakeDb harness used by
category-migration tests so SQL shape (table names + parameters) can be
asserted alongside service outputs.

Currency lock: USD / EUR / GBP / JPY / AUD all rejected up-front by the
service with a typed `currency_unsupported` code, no DB hit. The CAD
default is verified to land in the INSERT params explicitly.

Priced-kind safety: a snapshot save with one out-of-tolerance line must
NOT clear pre-existing lines (the DELETE is gated behind the validation
loop). A drift just within ε is accepted unchanged.

computeAccountReturn wiring: malformed dates are rejected client-side
without invoking the Rust command; missing active profile yields a typed
`transfer_active_profile_unknown`; partial-period payloads are forwarded
unchanged (null fields preserved).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

test(balance): add migration v9 integration on seeded DB 50fe0ab1ac

Three new Rust integration tests applied at the bottom of `lib.rs`'s
`#[cfg(test)] mod tests`. They exercise the realistic upgrade path: a v1
profile DB with imported transactions + categories already there gets the
v9 migration applied on top.

`migration_v9_preserves_existing_transactions_on_seeded_db` asserts no
row loss / data mutation after the migration runs. Spot-checks one
amount preserved verbatim and that the v9 seeded categories coexist with
the v1 categories table.

`integration_link_unlink_transfer_roundtrip_on_seeded_db` walks link →
joined-view read → blocked deletion (FK RESTRICT) → unlink → allowed
deletion → orphan-row sanity check. Covers the FK chain end-to-end on
real (non-stub) transaction ids.

`integration_modified_dietz_inputs_read_back_correctly_on_seeded_db`
mirrors the exact SQL used by `balance_commands.rs::read_value_at_or_before`
and `read_cash_flows`, asserting the snapshot-endpoint lookups and the
period-bounded JOINed cash flows return the expected shapes when run
against a seeded v1+v9 DB.

`integration_v9_preserves_v1_categories_and_keywords` verifies the
`categories.id` and `balance_categories.id` namespaces are independent
(same numeric id allowed on each table without collision).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

test(transactions): add non-regression test for inline transfer icon 5a54d37de5

Source-level structural test on `TransactionTable.tsx` to lock down the
inlined transfer icon contract introduced in #142. Without RTL or jsdom
in the dev-deps, the test reads the component source and asserts:

  - the icon is gated by `linkedTransfersByTxId?.has(row.id)`,
  - optional-chaining short-circuits cleanly when the prop is omitted
    (zero-impact on pre-#142 callers),
  - the prop is declared OPTIONAL on the component interface,
  - the `Link2` glyph comes from lucide-react,
  - tooltip + aria-label go through `transactions.transferIcon.*` i18n
    keys,
  - the row's description cell layout (truncate span + title) stays
    shared between linked and non-linked rows.

Catches the specific regression vectors: someone removing the gate,
renaming the prop, or breaking the optional-chaining pattern that
guarantees the page renders identically when no transfers are linked.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

chore: CHANGELOG entry for cross-cutting tests

PR Check / rust (push) Successful in 22m44s

Details

PR Check / frontend (push) Successful in 2m23s

Details

5274e51907

Bilingual entry under [Unreleased] documenting the integration test
suite added for Issue #144: end-to-end happy path, currency lock,
priced-kind tolerance safety, computeAccountReturn wiring, three Rust
migration-on-seeded-DB scenarios, and the source-level non-regression
test on the inlined transfer icon.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>