• Joined on 2026-02-23
maximus commented on pull request maximus/Simpl-Resultat#111 2026-04-19 12:31:23 +00:00
Highlights: default reference month to previous + YTD current year, user-changeable (#106)

Revue — APPROVE

Verdict

Implementation propre et bien testée. Les défauts demandés sont respectés et l'URL reste bookmarkable.

Points validés

  • defaultReferencePeriod
maximus created pull request maximus/Simpl-Resultat#111 2026-04-19 12:28:55 +00:00
Highlights: default reference month to previous + YTD current year, user-changeable (#106)
maximus created branch issue-106-highlights-default-ref-month in maximus/Simpl-Resultat 2026-04-19 12:28:36 +00:00
8b90cb6489 feat(reports/highlights): default reference month to previous month + YTD current year, user-changeable (#106)
maximus deleted branch issue-105-trends-stacked-area from maximus/Simpl-Resultat 2026-04-19 12:22:05 +00:00
maximus merged pull request maximus/Simpl-Resultat#110 2026-04-19 12:22:04 +00:00
feat(reports/trends): add stacked-area chart option for category view (#105)
maximus closed issue maximus/Simpl-Resultat#105 2026-04-19 12:22:04 +00:00
feat(reports/trends): add stacked-area chart option for category trends
maximus pushed to main at maximus/Simpl-Resultat 2026-04-19 12:22:04 +00:00
3842a1102a Merge pull request 'feat(reports/trends): add stacked-area chart option for category view (#105)' (#110) from issue-105-trends-stacked-area into main
94104c4223 refactor(reports/trends): rename chart type from 'line' to 'bar' to match actual rendering
02efc75542 feat(reports/trends): add stacked-area chart option for category view (#105)
Compare 3 commits »
maximus commented on pull request maximus/Simpl-Resultat#110 2026-04-19 11:26:46 +00:00
feat(reports/trends): add stacked-area chart option for category view (#105)

Revue — APPROVE

Verdict

Implementation propre. J'ai ajouté un commit de suivi pour corriger un nommage trompeur découvert pendant la revue.

Points validés

  • Toggle `TrendsChar…
maximus pushed to issue-105-trends-stacked-area at maximus/Simpl-Resultat 2026-04-19 11:26:26 +00:00
94104c4223 refactor(reports/trends): rename chart type from 'line' to 'bar' to match actual rendering
maximus created pull request maximus/Simpl-Resultat#110 2026-04-19 11:24:07 +00:00
feat(reports/trends): add stacked-area chart option for category view (#105)
maximus created branch issue-105-trends-stacked-area in maximus/Simpl-Resultat 2026-04-19 11:23:55 +00:00
maximus pushed to issue-105-trends-stacked-area at maximus/Simpl-Resultat 2026-04-19 11:23:55 +00:00
02efc75542 feat(reports/trends): add stacked-area chart option for category view (#105)
maximus deleted branch issue-104-compare-eight-col-table from maximus/Simpl-Resultat 2026-04-19 11:19:24 +00:00
maximus closed issue maximus/Simpl-Resultat#104 2026-04-19 11:19:23 +00:00
feat(reports/compare): mirror budget-vs-actual table structure in actual-vs-actual mode
maximus pushed to main at maximus/Simpl-Resultat 2026-04-19 11:19:23 +00:00
e95612a55d Merge pull request 'feat(reports/compare): 8-column table with monthly + cumulative YTD blocks (#104)' (#109) from issue-104-compare-eight-col-table into main
bd8a5732c6 feat(reports/compare): 8-column table with monthly + cumulative YTD blocks (#104)
Compare 2 commits »
maximus merged pull request maximus/Simpl-Resultat#109 2026-04-19 11:19:22 +00:00
feat(reports/compare): 8-column table with monthly + cumulative YTD blocks (#104)
maximus commented on pull request maximus/Simpl-Resultat#109 2026-04-19 01:20:19 +00:00
feat(reports/compare): 8-column table with monthly + cumulative YTD blocks (#104)

Revue — APPROVE

Verdict

Refonte substantielle et bien structurée. Le tableau Réel-vs-Réel réplique fidèlement la structure 8 colonnes du tableau Réel-vs-Budget, avec des…

maximus created pull request maximus/Simpl-Resultat#109 2026-04-19 01:18:20 +00:00
feat(reports/compare): 8-column table with monthly + cumulative YTD blocks (#104)
maximus created branch issue-104-compare-eight-col-table in maximus/Simpl-Resultat 2026-04-19 01:17:39 +00:00