• Joined on 2026-02-23
maximus pushed to issue-47-license-ui-card at maximus/Simpl-Resultat 2026-04-09 12:54:41 +00:00
a6ffd2c4c4 feat: license card in settings (#47)
maximus pushed to master at maximus/simpl-liste 2026-04-09 12:53:12 +00:00
1df41cef1f fix: auto-apply migrations on startup + cleanup duplicate inboxes (#60)
maximus commented on pull request maximus/Simpl-Resultat#56 2026-04-09 12:50:50 +00:00
feat: license validation commands + entitlements system (#46)

Review (sprint inline) — APPROVE

Le code respecte le scope de l'issue et implémente les correctifs sécurité demandés au spec-monetisation review.

Points vérifiés

  • `jsonwebtoke…
maximus created pull request maximus/Simpl-Resultat#56 2026-04-09 12:50:02 +00:00
feat: license validation commands + entitlements system (#46)
maximus created branch issue-46-license-commands-entitlements in maximus/Simpl-Resultat 2026-04-09 12:49:49 +00:00
a9eacc8b9a feat: add license validation and entitlements (Rust) (#46)
maximus commented on pull request maximus/Simpl-Resultat#55 2026-04-09 12:28:53 +00:00
fix: migrate PIN hashing from SHA-256 to Argon2id (#54)

Verdict: APPROVE

Summary: Clean migration from SHA-256 to Argon2id for PIN hashing with transparent backward compatibility and automatic rehash of legacy PINs on verification. Complete…

maximus pushed to fix/simpl-resultat-54-argon2id-pin at maximus/Simpl-Resultat 2026-04-09 12:01:12 +00:00
c301b25450 fix: wrap rehash updateProfile in try/catch for best-effort (#54)
maximus commented on pull request maximus/Simpl-Resultat#55 2026-04-09 11:00:59 +00:00
fix: migrate PIN hashing from SHA-256 to Argon2id (#54)

Reviewer automatique — needs-fix

Le backend est solide (Argon2id, constant-time, rehash best-effort via .ok()). Cependant, le probleme signale au round 2 n'est que partiellement corrige :…

maximus pushed to fix/simpl-resultat-54-argon2id-pin at maximus/Simpl-Resultat 2026-04-09 10:02:20 +00:00
086650c88a fix: make legacy PIN rehash non-blocking in verify_pin (#54)
maximus commented on pull request maximus/Simpl-Resultat#55 2026-04-09 09:02:31 +00:00
fix: migrate PIN hashing from SHA-256 to Argon2id (#54)

Reviewer automatique — needs-fix

Les corrections du round 1 (re-hachage Argon2id, tests, comparaison constant-time) sont bien implementees. Cependant, une erreur lors de la persistance du…

maximus pushed to fix/simpl-resultat-54-argon2id-pin at maximus/Simpl-Resultat 2026-04-09 06:05:16 +00:00
8e27be8c41 fix: address reviewer feedback (#54)
maximus commented on pull request maximus/Simpl-Resultat#55 2026-04-09 05:00:35 +00:00
fix: migrate PIN hashing from SHA-256 to Argon2id (#54)

Reviewer automatique — needs-fix

Deux exigences explicites de l'issue ne sont pas implémentées : (1) le re-hachage automatique des PINs legacy SHA-256 vers Argon2id lors d'une vérification…

maximus created pull request maximus/Simpl-Resultat#55 2026-04-09 04:03:07 +00:00
fix: migrate PIN hashing from SHA-256 to Argon2id (#54)
maximus created branch fix/simpl-resultat-54-argon2id-pin in maximus/Simpl-Resultat 2026-04-09 04:02:54 +00:00
maximus pushed to fix/simpl-resultat-54-argon2id-pin at maximus/Simpl-Resultat 2026-04-09 04:02:54 +00:00
3020a9cfc9 fix: migrate PIN hashing from SHA-256 to Argon2id (#54)
maximus released v1.6.0 at maximus/simpl-liste 2026-04-09 01:56:17 +00:00
maximus opened issue maximus/Simpl-Resultat#54 2026-04-09 01:55:38 +00:00
fix: migrate PIN hashing from SHA-256 to Argon2id
maximus opened issue maximus/Simpl-Resultat#53 2026-04-09 01:55:17 +00:00
feat: online activation and machine limit enforcement
maximus opened issue maximus/Simpl-Resultat#52 2026-04-09 01:54:56 +00:00
feat: purchase page on lacompagniemaximus.com