maximus
0 followers · 0 following
  • Joined on 2026-02-23
Repositories
3
 Projects Packages Public activity Starred repositories
maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 19:14:33 +00:00
4e92882724 fix: restrict last_check file perms + add useAuth to architecture docs
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 19:08:30 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

PR Review — feat: Maximus Account OAuth2 + machine activation (#51, #53)

Verdict: REQUEST_CHANGES

Solid implementation overall — clean PKCE flow, proper verifier lifetime management…

maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 19:04:08 +00:00
ca3005bc0e fix: use write_restricted for account.json (0600 perms)
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 18:59:59 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

🔍 PR Review — REQUEST_CHANGES

Summary

The OAuth2 PKCE flow and machine activation features are well-structured overall, with good separation of concerns (Rust commands, TS services,…

maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 18:58:20 +00:00
9e26ad58d1 fix: use base64 crate, restrict token file perms, safer chrono_now
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 18:48:04 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

🔍 PR Review — REQUEST_CHANGES

Summary

Solid OAuth2 PKCE flow and machine activation implementation with good architectural decisions (PKCE verifier in memory, graceful degradation,…

maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 18:43:27 +00:00
be5f6a55c5 fix: URL-decode auth code + replace Mutex unwrap with map_err
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 18:23:37 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

🔍 PR Review — feat: Maximus Account OAuth2 + machine activation (#51, #53)

Verdict: REQUEST_CHANGES ⛔

Bonne PR dans l'ensemble — l'architecture OAuth2 PKCE est solide,…

maximus created pull request maximus/Simpl-Resultat#65 2026-04-10 18:19:55 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)
maximus created branch issue-51-compte-maximus-oauth in maximus/Simpl-Resultat 2026-04-10 18:19:25 +00:00
maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 18:19:25 +00:00
b53a902f11 feat: Maximus Account OAuth2 PKCE + machine activation + subscription check (#51, #53)
maximus closed issue maximus/simpl-liste#59 2026-04-10 15:38:16 +00:00
sync - bogue refresh
maximus pushed to main at maximus/Simpl-Resultat 2026-04-10 14:28:29 +00:00
877ace370f Merge pull request 'feat: license system (UI card + auto-update gating) (#47, #48)' (#64) from issue-46-license-commands-entitlements into main
dd106a1df6 Merge pull request 'feat: gate auto-updates behind license entitlement (#48)' (#58) from issue-48-gate-auto-updates into issue-46-license-commands-entitlements
44f98549b5 Merge pull request 'feat: license UI card in settings (#47)' (#57) from issue-47-license-ui-card into issue-46-license-commands-entitlements
6d67ab8935 feat: gate auto-updates behind license entitlement (#48)
2da2de183a feat: license card in settings (#47)
Compare 5 commits »
maximus merged pull request maximus/Simpl-Resultat#64 2026-04-10 14:28:28 +00:00
feat: license system (UI card + auto-update gating) (#47, #48)
maximus created pull request maximus/Simpl-Resultat#64 2026-04-10 14:28:19 +00:00
feat: license system (UI card + auto-update gating) (#47, #48)
maximus commented on issue maximus/Simpl-Resultat#48 2026-04-10 14:05:39 +00:00
feat: gate auto-updates behind license entitlement

Fermé par PR #58 (mergée). Les mises à jour automatiques sont maintenant conditionnées à l'entitlement auto-update dans la licence.

maximus commented on issue maximus/Simpl-Resultat#47 2026-04-10 14:05:37 +00:00
feat: license UI card in settings

Fermé par PR #57 (mergée). Carte de licence ajoutée dans les paramètres avec affichage du statut, entitlements et actions activation/suppression.

dd106a1df6 Merge pull request 'feat: gate auto-updates behind license entitlement (#48)' (#58) from issue-48-gate-auto-updates into issue-46-license-commands-entitlements
6d67ab8935 feat: gate auto-updates behind license entitlement (#48)
Compare 2 commits »
maximus merged pull request maximus/Simpl-Resultat#58 2026-04-10 13:55:40 +00:00
feat: gate auto-updates behind license entitlement (#48)
maximus closed issue maximus/Simpl-Resultat#48 2026-04-10 13:55:40 +00:00
feat: gate auto-updates behind license entitlement