• Joined on 2026-02-23
maximus commented on pull request maximus/simpl-liste#93 2026-05-30 19:11:45 +00:00
chore(web): document set-state-in-effect on ThemeToggle localStorage read (#90)

Review — APPROVE

Verdict : APPROVE

Changement comment-only validé. Le directive eslint-disable-next-line react-hooks/set-state-in-effect cible la bonne ligne et supprime une erreur…

maximus created pull request maximus/simpl-liste#94 2026-05-30 19:05:34 +00:00
fix(security): override @expo/cli ws to ^8.20.1 (GHSA-58qx-3vcg-4xpx) (#92)
maximus created branch issue-92-ws-override in maximus/simpl-liste 2026-05-30 19:05:12 +00:00
maximus pushed to issue-92-ws-override at maximus/simpl-liste 2026-05-30 19:05:12 +00:00
9ee5372404 fix(security): override @expo/cli ws to ^8.20.1 (GHSA-58qx-3vcg-4xpx) (#92)
maximus created pull request maximus/simpl-liste#93 2026-05-30 18:58:07 +00:00
chore(web): document set-state-in-effect on ThemeToggle localStorage read (#90)
maximus created branch issue-90-themetoggle-lint-disable in maximus/simpl-liste 2026-05-30 18:57:46 +00:00
maximus pushed to issue-90-themetoggle-lint-disable at maximus/simpl-liste 2026-05-30 18:57:46 +00:00
e9ddf27eab chore(web): document set-state-in-effect on ThemeToggle localStorage read (#90)
maximus pushed to master at maximus/simpl-liste 2026-05-30 18:53:59 +00:00
7750214c64 state: sync after #70
maximus pushed to master at maximus/simpl-liste 2026-05-30 18:52:36 +00:00
97cf9ce0f7 Merge pull request 'chore(web): fix prefer-const and remove unused import' (#91) from chore/web-lint-cleanup into master
4086aac50c chore(web): fix prefer-const and remove unused import
Compare 2 commits »
maximus merged pull request maximus/simpl-liste#91 2026-05-30 18:52:34 +00:00
chore(web): fix prefer-const and remove unused import
maximus merged pull request maximus/simpl-liste#89 2026-05-30 18:52:23 +00:00
fix(web): resolve display name from userInfo, not just claims (#70)
maximus closed issue maximus/simpl-liste#70 2026-05-30 18:52:23 +00:00
Harmoniser le display name avec la vitrine (userInfo au lieu de claims)
maximus pushed to master at maximus/simpl-liste 2026-05-30 18:52:23 +00:00
7343f993ee Merge pull request 'fix(web): resolve display name from userInfo, not just claims (#70)' (#89) from issue-70-harmonize-display-name into master
3637879f90 fix(web): resolve display name from userInfo, not just claims (#70)
Compare 2 commits »
maximus commented on pull request maximus/simpl-liste#91 2026-05-30 18:26:35 +00:00
chore(web): fix prefer-const and remove unused import

Review — APPROVE

Trois corrections lint mécaniques et pré-existantes dans web/. Toutes les affirmations de la PR vérifiées contre le working tree et le tooling.

Vérification

-…

maximus opened issue maximus/simpl-liste#92 2026-05-30 18:25:38 +00:00
[security] deps: vulnerability in ws (medium)
maximus created pull request maximus/simpl-liste#91 2026-05-30 18:23:08 +00:00
chore(web): fix prefer-const and remove unused import
maximus created branch chore/web-lint-cleanup in maximus/simpl-liste 2026-05-30 18:22:47 +00:00
maximus pushed to chore/web-lint-cleanup at maximus/simpl-liste 2026-05-30 18:22:47 +00:00
4086aac50c chore(web): fix prefer-const and remove unused import
maximus opened issue maximus/simpl-liste#90 2026-05-30 18:22:31 +00:00
ThemeToggle: lint react-hooks/set-state-in-effect (hydratation localStorage)
maximus commented on pull request maximus/simpl-liste#89 2026-05-30 18:14:18 +00:00
fix(web): resolve display name from userInfo, not just claims (#70)

/pr-review — APPROVE

Summary — Correct, minimal, type-safe fix. The display-name resolution is moved to the userInfo endpoint with the ID-token claims preserved as fallback; the change…