maximus
0 followers · 0 following
  • Joined on 2026-02-23
Repositories
3
 Projects Packages Public activity Starred repositories
maximus commented on pull request maximus/Simpl-Resultat#87 2026-04-14 12:27:38 +00:00
docs: ADR 0006 + changelog + architecture for OAuth keychain (#82)

Review — APPROVE ✓

PR docs-only, revue rapide.

Correctness

  • ✓ ADR-0006 référence correctement les PRs #83-#87 et les issues #66, #78-#82
  • ✓ architecture.md : nouveau…
maximus created pull request maximus/Simpl-Resultat#87 2026-04-14 12:26:55 +00:00
docs: ADR 0006 + changelog + architecture for OAuth keychain (#82)
maximus created branch issue-82-wrap-up in maximus/Simpl-Resultat 2026-04-14 12:26:25 +00:00
maximus pushed to issue-82-wrap-up at maximus/Simpl-Resultat 2026-04-14 12:26:25 +00:00
65bc7f5130 docs: ADR 0006 + changelog + architecture for OAuth keychain (#82)
maximus deleted branch issue-81-fallback-banner from maximus/Simpl-Resultat 2026-04-14 12:21:41 +00:00
maximus pushed to main at maximus/Simpl-Resultat 2026-04-14 12:21:40 +00:00
745f71782f Merge pull request 'feat: settings banner when OAuth tokens use file fallback (#81)' (#86) from issue-81-fallback-banner into main
9a9d3c89b9 feat: dismissable banner with session-storage memory (#81)
3b1c41c48e feat: settings banner when OAuth tokens fall back to file store (#81)
Compare 3 commits »
maximus closed issue maximus/Simpl-Resultat#81 2026-04-14 12:21:39 +00:00
[#4] Bannière UI quand le fallback plaintext est actif
maximus merged pull request maximus/Simpl-Resultat#86 2026-04-14 12:21:38 +00:00
feat: settings banner when OAuth tokens use file fallback (#81)
maximus commented on pull request maximus/Simpl-Resultat#86 2026-04-14 12:21:17 +00:00
feat: settings banner when OAuth tokens use file fallback (#81)

Review — APPROVE ✓

Security

  • ✓ Aucune chaîne en dur — tout passe par i18n (fr/en)
  • ✓ Pas de XSS : seulement du texte rendu via React
  • ✓ sessionStorage dans un try/catch…
maximus pushed to issue-81-fallback-banner at maximus/Simpl-Resultat 2026-04-14 12:20:23 +00:00
9a9d3c89b9 feat: dismissable banner with session-storage memory (#81)
maximus created pull request maximus/Simpl-Resultat#86 2026-04-14 12:19:08 +00:00
feat: settings banner when OAuth tokens use file fallback (#81)
maximus created branch issue-81-fallback-banner in maximus/Simpl-Resultat 2026-04-14 12:18:44 +00:00
maximus pushed to issue-81-fallback-banner at maximus/Simpl-Resultat 2026-04-14 12:18:44 +00:00
3b1c41c48e feat: settings banner when OAuth tokens fall back to file store (#81)
maximus pushed to main at maximus/Simpl-Resultat 2026-04-14 12:12:18 +00:00
cf31666c35 Merge pull request 'feat: HMAC-verified account cache (#80)' (#85) from issue-80-subscription-integrity into main
2d7d1e05d2 feat: HMAC-sign cached account info to close subscription tampering (#80)
Compare 2 commits »
maximus deleted branch issue-80-subscription-integrity from maximus/Simpl-Resultat 2026-04-14 12:12:18 +00:00
maximus merged pull request maximus/Simpl-Resultat#85 2026-04-14 12:12:17 +00:00
feat: HMAC-verified account cache (#80)
maximus closed issue maximus/Simpl-Resultat#80 2026-04-14 12:12:17 +00:00
[#3] Intégrité de subscription_status (anti-tampering gating licence)
maximus commented on pull request maximus/Simpl-Resultat#85 2026-04-14 12:10:39 +00:00
feat: HMAC-verified account cache (#80)

Review — APPROVE ✓

Security

  • ✓ HMAC-SHA256 via hmac crate — primitive correcte
  • ✓ verify_slice est constant-time (pas de timing leak)
  • ✓ Clé 32 bytes générée via…
maximus created pull request maximus/Simpl-Resultat#85 2026-04-14 12:08:55 +00:00
feat: HMAC-verified account cache (#80)
maximus created branch issue-80-subscription-integrity in maximus/Simpl-Resultat 2026-04-14 12:07:51 +00:00