maximus

maximus pushed to main at maximus/Simpl-Resultat

2026-06-10 01:07:53 +00:00

cbaa9cb6d0 Merge pull request 'feat(balance): reducer holdings + dispatch account.kind (#213)' (#222) from issue-213-reducer-dispatch into main

737654579f feat(balance): rewrite snapshot editor reducer for holdings + dispatch on account.kind (#213)

Compare 2 commits »

maximus merged pull request maximus/Simpl-Resultat#222

2026-06-10 01:07:52 +00:00

feat(balance): reducer holdings + dispatch account.kind (#213)

maximus closed issue maximus/Simpl-Resultat#213

2026-06-10 01:07:52 +00:00

feat(balance): refonte editeur — reducer holdings + dispatch account.kind

maximus closed issue maximus/Simpl-Resultat#212

2026-06-10 01:07:50 +00:00

feat(balance): service securities + save snapshot detaille (holdings)

maximus pushed to main at maximus/Simpl-Resultat

2026-06-10 01:07:50 +00:00

205e1ded54 Merge pull request 'feat(balance): securities service + detailed snapshot save (#212)' (#221) from issue-212-service-securities into main

582cf4012d feat(balance): securities service + transactional detailed snapshot save (#212)

Compare 2 commits »

maximus pushed to main at maximus/Simpl-Resultat

2026-06-10 01:07:49 +00:00

4e4e4bd0d2 Merge pull request 'feat(balance): convert priced accounts to detailed (v16) (#211)' (#220) from issue-211-conversion-v16 into main

90c115e0c0 feat(balance): convert existing priced accounts to detailed (migration v16) (#211)

Compare 2 commits »

maximus merged pull request maximus/Simpl-Resultat#221

2026-06-10 01:07:49 +00:00

feat(balance): securities service + detailed snapshot save (#212)

maximus merged pull request maximus/Simpl-Resultat#220

2026-06-10 01:07:47 +00:00

feat(balance): convert priced accounts to detailed (v16) (#211)

maximus closed issue maximus/Simpl-Resultat#211

2026-06-10 01:07:47 +00:00

feat(balance): conversion des comptes cotes existants (migration v16)

maximus pushed to main at maximus/Simpl-Resultat

2026-06-10 01:07:46 +00:00

604b97fc4d Merge pull request 'feat(balance): schema & migrations v14/v15 + types (#210)' (#219) from issue-210-schema-migrations into main

a1c3dafcd0 feat(balance): schema & migrations v14/v15 + types (securities, holdings, account.kind) (#210)

Compare 2 commits »

maximus merged pull request maximus/Simpl-Resultat#219

2026-06-10 01:07:45 +00:00

feat(balance): schema & migrations v14/v15 + types (#210)

maximus closed issue maximus/Simpl-Resultat#210

2026-06-10 01:07:45 +00:00

feat(balance): schema & migrations v14/v15 + types (securities, holdings, account.kind)

maximus commented on pull request maximus/Simpl-Resultat#220

2026-06-06 20:36:28 +00:00

feat(balance): convert priced accounts to detailed (v16) (#211)

Disposition (décision Max) : merge + fix-forward.

La review a relevé un vrai bug (garde d'abort v16 trop large → blocage de lancement pour un compte simple à symbole résiduel). La…

maximus opened issue maximus/Simpl-Resultat#228

2026-06-06 20:36:10 +00:00

fix(balance): v16 abort guard too broad — scope to convertible accounts (asset_type NOT NULL)

maximus commented on pull request maximus/Simpl-Resultat#221

2026-06-06 19:38:34 +00:00

feat(balance): securities service + detailed snapshot save (#212)

Adversarial review — PR #221 (issue #212) · APPROVE ✅

Link 3/9, the riskiest TS PR. Verified the FULL diff (+1324/−93, 2 files) plus the v14/v16 schema, the TS types, and a…

maximus commented on pull request maximus/Simpl-Resultat#220

2026-06-06 19:38:02 +00:00

feat(balance): convert priced accounts to detailed (v16) (#211)

Adversarial review — PR #220 (v16 priced→detailed conversion)

Verdict: 🔴 REQUEST_CHANGES — one must-fix (startup-bricking guard false-positive). The conversion logic and atomicity…

maximus commented on pull request maximus/Simpl-Resultat#222

2026-06-06 19:36:57 +00:00

feat(balance): reducer holdings + dispatch account.kind (#213)

Adversarial review — PR #222 (Issue #213) — APPROVE ✅

Link 4/9 (reducer rewrite). Reviewed the full diff (1083+/363−, 8 files) against the base branch issue-212-service-securities…

maximus commented on pull request maximus/Simpl-Resultat#225

2026-06-06 19:36:31 +00:00

feat(balance): detail-account wizard (pivot date) (#215)

Adversarial review — PR #225 (Issue #215, Link 7/9)

Verdict: APPROVE ✅ — no must-fix issues.

Stacked on issue-216-drilldown-gain; base→head diff confirms the table change is…

maximus commented on pull request maximus/Simpl-Resultat#227

2026-06-06 19:35:56 +00:00

docs(balance): ADR 0015 + guide + architecture + CHANGELOG (#218)

Adversarial review — PR #227 (issue #218) · docs(balance): ADR 0015 + guide + architecture + CHANGELOG

Verdict : APPROVE ✅ — Link 9/9 (docs-only). Toutes les réconciliations de…

maximus commented on pull request maximus/Simpl-Resultat#224

2026-06-06 19:35:34 +00:00

feat(balance): per-security drill-down + latent gain (#216)

Adversarial review — PR #224 (Link 6/9, issue #216)

Verdict: APPROVE ✅ — no must-fix. Reviewed the full diff (729+/7-, 8 files) and the head-branch sources for the dependencies…