• Joined on 2026-02-23
maximus commented on pull request maximus/Simpl-Resultat#220 2026-06-06 20:36:28 +00:00
feat(balance): convert priced accounts to detailed (v16) (#211)

Disposition (décision Max) : merge + fix-forward.

La review a relevé un vrai bug (garde d'abort v16 trop large → blocage de lancement pour un compte simple à symbole résiduel). La…

maximus opened issue maximus/Simpl-Resultat#228 2026-06-06 20:36:10 +00:00
fix(balance): v16 abort guard too broad — scope to convertible accounts (asset_type NOT NULL)
maximus commented on pull request maximus/Simpl-Resultat#221 2026-06-06 19:38:34 +00:00
feat(balance): securities service + detailed snapshot save (#212)

Adversarial review — PR #221 (issue #212) · APPROVE

Link 3/9, the riskiest TS PR. Verified the FULL diff (+1324/−93, 2 files) plus the v14/v16 schema, the TS types, and a…

maximus commented on pull request maximus/Simpl-Resultat#220 2026-06-06 19:38:02 +00:00
feat(balance): convert priced accounts to detailed (v16) (#211)

Adversarial review — PR #220 (v16 priced→detailed conversion)

Verdict: 🔴 REQUEST_CHANGES — one must-fix (startup-bricking guard false-positive). The conversion logic and atomicity…

maximus commented on pull request maximus/Simpl-Resultat#222 2026-06-06 19:36:57 +00:00
feat(balance): reducer holdings + dispatch account.kind (#213)

Adversarial review — PR #222 (Issue #213) — APPROVE

Link 4/9 (reducer rewrite). Reviewed the full diff (1083+/363−, 8 files) against the base branch issue-212-service-securities

maximus commented on pull request maximus/Simpl-Resultat#225 2026-06-06 19:36:31 +00:00
feat(balance): detail-account wizard (pivot date) (#215)

Verdict: APPROVE — no must-fix issues.

Stacked on issue-216-drilldown-gain; base→head diff confirms the table change is…

maximus commented on pull request maximus/Simpl-Resultat#227 2026-06-06 19:35:56 +00:00
docs(balance): ADR 0015 + guide + architecture + CHANGELOG (#218)

Adversarial review — PR #227 (issue #218) · docs(balance): ADR 0015 + guide + architecture + CHANGELOG

Verdict : APPROVE — Link 9/9 (docs-only). Toutes les réconciliations de…

maximus commented on pull request maximus/Simpl-Resultat#224 2026-06-06 19:35:34 +00:00
feat(balance): per-security drill-down + latent gain (#216)

Verdict: APPROVE — no must-fix. Reviewed the full diff (729+/7-, 8 files) and the head-branch sources for the dependencies…

maximus commented on pull request maximus/Simpl-Resultat#226 2026-06-06 19:35:34 +00:00
test(balance): integration + regression coverage (#217)

Adversarial review — PR #226 (test: integration + regression coverage, #217)

Verdict: APPROVE

Pure-additive test PR (deletions=0, 2 files: lib.rs + balance-flow.test.ts).…

maximus commented on pull request maximus/Simpl-Resultat#223 2026-06-06 19:35:34 +00:00
feat(balance): multi-security entry UI + SecurityPicker (#214)

Verdict: APPROVE. No must-fix issues. The pure helpers are correct, the stale-price drop is sound end-to-end, i18n parity is exact,…

maximus commented on pull request maximus/Simpl-Resultat#219 2026-06-06 19:35:12 +00:00
feat(balance): schema & migrations v14/v15 + types (#210)

Adversarial review — PR #219 (issue #210) — Bilan Étape 2, schema & migrations v14/v15 + types

Verdict : APPROVE (1 suggestion importante à traiter avant les PRs consommatrices, 2…

maximus created pull request maximus/Simpl-Resultat#227 2026-06-06 18:17:36 +00:00
docs(balance): ADR 0015 + guide + architecture + CHANGELOG (#218)
maximus created branch issue-218-docs in maximus/Simpl-Resultat 2026-06-06 18:17:11 +00:00
maximus pushed to issue-218-docs at maximus/Simpl-Resultat 2026-06-06 18:17:11 +00:00
d41ccbd618 docs(balance): ADR 0015 + guide + architecture + CHANGELOG for per-security detail (#218)
maximus created pull request maximus/Simpl-Resultat#226 2026-06-06 18:04:22 +00:00
test(balance): integration + regression coverage (#217)
maximus created branch issue-217-tests in maximus/Simpl-Resultat 2026-06-06 18:04:04 +00:00
maximus pushed to issue-217-tests at maximus/Simpl-Resultat 2026-06-06 18:04:04 +00:00
6c82501d6d test(balance): integration + regression coverage for per-security detail (#217)
maximus created pull request maximus/Simpl-Resultat#225 2026-06-06 17:56:11 +00:00
feat(balance): detail-account wizard (pivot date) (#215)
maximus created branch issue-215-detail-wizard in maximus/Simpl-Resultat 2026-06-06 17:56:00 +00:00
maximus pushed to issue-215-detail-wizard at maximus/Simpl-Resultat 2026-06-06 17:56:00 +00:00
9608fd3618 feat(balance): detail-account wizard (toggle to detailed at pivot date) (#215)