maximus
0 followers · 0 following
  • Joined on 2026-02-23
Repositories
3
 Projects Packages Public activity Starred repositories
maximus merged pull request maximus/Simpl-Resultat#65 2026-04-10 19:38:28 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)
maximus closed issue maximus/Simpl-Resultat#51 2026-04-10 19:38:28 +00:00
feat: Compte Maximus (Logto OAuth2) in desktop app
maximus opened issue maximus/simpl-liste#68 2026-04-10 19:36:24 +00:00
Intégrer widget feedback (Feedback Hub)
maximus opened issue maximus/Simpl-Resultat#67 2026-04-10 19:36:24 +00:00
Intégrer widget feedback (Feedback Hub)
maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 19:35:13 +00:00
e314bbe1e3 fix: remove handle_auth_callback from invoke_handler
maximus opened issue maximus/Simpl-Resultat#66 2026-04-10 19:34:53 +00:00
feat: migrate OAuth tokens from plaintext JSON to OS keychain
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 19:26:56 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

🔍 PR Review — REQUEST_CHANGES

Reviewer: Claude Code (adversarial review)

La PR est bien structurée et couvre OAuth2 PKCE, activation de machines, et détection Premium. Cependant,…

maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 19:24:55 +00:00
60b995394e fix: tighten CSP img-src, show initials instead of external avatar
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 19:19:28 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

PR Review — #65 feat: Maximus Account OAuth2 + machine activation

Verdict: REQUEST_CHANGES

Solid implementation of OAuth2 PKCE and machine activation. Architecture is clean, i18n…

maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 19:14:33 +00:00
4e92882724 fix: restrict last_check file perms + add useAuth to architecture docs
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 19:08:30 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

PR Review — feat: Maximus Account OAuth2 + machine activation (#51, #53)

Verdict: REQUEST_CHANGES

Solid implementation overall — clean PKCE flow, proper verifier lifetime management…

maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 19:04:08 +00:00
ca3005bc0e fix: use write_restricted for account.json (0600 perms)
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 18:59:59 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

🔍 PR Review — REQUEST_CHANGES

Summary

The OAuth2 PKCE flow and machine activation features are well-structured overall, with good separation of concerns (Rust commands, TS services,…

maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 18:58:20 +00:00
9e26ad58d1 fix: use base64 crate, restrict token file perms, safer chrono_now
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 18:48:04 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

🔍 PR Review — REQUEST_CHANGES

Summary

Solid OAuth2 PKCE flow and machine activation implementation with good architectural decisions (PKCE verifier in memory, graceful degradation,…

maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 18:43:27 +00:00
be5f6a55c5 fix: URL-decode auth code + replace Mutex unwrap with map_err
maximus commented on pull request maximus/Simpl-Resultat#65 2026-04-10 18:23:37 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)

🔍 PR Review — feat: Maximus Account OAuth2 + machine activation (#51, #53)

Verdict: REQUEST_CHANGES ⛔

Bonne PR dans l'ensemble — l'architecture OAuth2 PKCE est solide,…

maximus created pull request maximus/Simpl-Resultat#65 2026-04-10 18:19:55 +00:00
feat: Maximus Account OAuth2 + machine activation (#51, #53)
maximus created branch issue-51-compte-maximus-oauth in maximus/Simpl-Resultat 2026-04-10 18:19:25 +00:00
maximus pushed to issue-51-compte-maximus-oauth at maximus/Simpl-Resultat 2026-04-10 18:19:25 +00:00
b53a902f11 feat: Maximus Account OAuth2 PKCE + machine activation + subscription check (#51, #53)