ci: keep the boot check off proxies, catch continue-on-error in any literal spelling (#35) #42

Merged
maximus merged 7 commits from issue-35-ci-pin-followups into main 2026-10-01 22:00:54 +00:00
2 changed files with 5 additions and 4 deletions
Showing only changes of commit 13d46e05ef - Show all commits

View file

@ -98,8 +98,9 @@ describe("CI workflow", () => {
// The detector itself, through the same comment stripping as `ciCode`. // The detector itself, through the same comment stripping as `ciCode`.
// Anchored at the start of the line again, it would miss the flow mapping, // Anchored at the start of the line again, it would miss the flow mapping,
// the quoted key and the anchor; with a colon required after the word, the // the quoted key and the anchor; with a colon required right after the word,
// anchor. // the quoted key and the anchor; with a closing quote allowed before that
// colon, the anchor alone.
test.each([ test.each([
["a block key", " - name: x\n run: npm test\n continue-on-error: true"], ["a block key", " - name: x\n run: npm test\n continue-on-error: true"],
["a list item", " - continue-on-error: true\n run: npm test"], ["a list item", " - continue-on-error: true\n run: npm test"],

View file

@ -72,8 +72,8 @@ CMD_SH=$(printf '%s' "$CMD_LINE" | node -e '
# check a server we never started. So refuse up front: the port counts as free # check a server we never started. So refuse up front: the port counts as free
# only when curl gets "connection refused" (exit 7). Any other exit — an HTTP # only when curl gets "connection refused" (exit 7). Any other exit — an HTTP
# answer (0), a listener that accepts and stalls (28), a non-HTTP service # answer (0), a listener that accepts and stalls (28), a non-HTTP service
# (52, 56) — means it is taken. No proxy answers in the port's place: NO_PROXY # (52, 56) — means it is taken. No proxy answers in the port's place: no_proxy
# is exported at the top. # and NO_PROXY are exported at the top.
command -v curl >/dev/null 2>&1 || fail "curl is required" command -v curl >/dev/null 2>&1 || fail "curl is required"
RC=0 RC=0
curl -s -o /dev/null --max-time 2 "http://127.0.0.1:$PORT/" || RC=$? curl -s -o /dev/null --max-time 2 "http://127.0.0.1:$PORT/" || RC=$?