maximus/Simpl-Resultat
1
0
Fork 0
Code Issues 6 Pull requests 1 Projects Releases 23 Packages Wiki Activity Actions
Simpl-Resultat/src/services
History
le king fu 8c3a64d172 fix(balance): re-check collisions in-transaction in proposeStarterAccounts (S3) 
Adds defense-in-depth: each iteration runs a SELECT COUNT(*) WHERE name=?
AND balance_category_id=? AND archived_at IS NULL inside the BEGIN/COMMIT
block, immediately before its INSERT. On a hit, the iteration skips the
INSERT silently and the returned ids array excludes the skipped starter.

Rationale: balance_accounts has no UNIQUE constraint on (name, category)
and the upstream pre-filter (getStarterCollisions) is best-effort. If a
race or a bypass slips a duplicate through, the in-txn check catches it
without surfacing a confusing error to the user.

Existing two tests in StarterAccountsModal.test.tsx updated to mock the
new SELECT call sequence; new test "skips silently when in-txn collision
check finds an existing account" added.

Suggestion S3 from PR #185 review (#187).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-03 16:27:16 -04:00
..
adjustmentService.ts feat: add Budget and Adjustments pages with full functionality 2026-02-12 00:58:43 +00:00
authService.ts feat: settings banner when OAuth tokens fall back to file store (#81) 2026-04-14 08:18:41 -04:00
balance.service.test.ts fix(balance): atomic snapshot save with BEGIN/COMMIT + cleanup migration 2026-05-01 07:33:44 -04:00
balance.service.ts fix(balance): re-check collisions in-transaction in proposeStarterAccounts (S3) 2026-05-03 16:27:16 -04:00
budgetService.ts feat: show actual transactions in budget previous year column 2026-03-10 23:03:26 -04:00
categorizationService.test.ts feat: category zoom + secure AddKeywordDialog with context menu (#74) 2026-04-14 15:09:17 -04:00
categorizationService.ts feat: category zoom + secure AddKeywordDialog with context menu (#74) 2026-04-14 15:09:17 -04:00
categoryBackupService.test.ts test(categories): complete test coverage for migration flow (#123) 2026-04-21 19:25:13 -04:00
categoryBackupService.ts feat(categories): add categoryBackupService for pre-migration SREF backup (#120) 2026-04-19 15:46:23 -04:00
categoryMappingService.test.ts test(categories): complete test coverage for migration flow (#123) 2026-04-21 19:25:13 -04:00
categoryMappingService.ts feat(categories): add categoryMappingService (4-pass algo) (#119) 2026-04-20 21:01:55 -04:00
categoryMigrationService.test.ts test(categories): complete test coverage for migration flow (#123) 2026-04-21 19:25:13 -04:00
categoryMigrationService.ts feat(categories): add 3-step migration page + categoryMigrationService (#121) 2026-04-20 21:31:21 -04:00
categoryRestoreService.test.ts feat(categories): add restore backup banner and permanent restore action (#122) 2026-04-20 21:47:43 -04:00
categoryRestoreService.ts feat(categories): add restore backup banner and permanent restore action (#122) 2026-04-20 21:47:43 -04:00
categoryService.ts feat(categories): add v1 IPC seed, i18n keys, and migration v8 (#115) 2026-04-19 16:41:55 -04:00
categoryTaxonomyService.test.ts feat(categories): add categoryTaxonomyService + useCategoryTaxonomy hook (#116) 2026-04-20 20:53:15 -04:00
categoryTaxonomyService.ts feat(categories): add categoryTaxonomyService + useCategoryTaxonomy hook (#116) 2026-04-20 20:53:15 -04:00
dashboardService.ts Bump version to 0.6.0 — Reports enhancements and comment visibility fix 2026-03-04 21:01:13 -05:00
dataExportService.ts feat: make settings data imports visible in Import History 2026-02-15 13:38:51 +00:00
db.ts Fix migration checksum mismatch on startup 2026-03-01 09:17:35 -05:00
feedbackService.test.ts feat: feedback hub widget in Settings Logs card (#67) 2026-04-17 14:36:26 +00:00
feedbackService.ts feat: feedback hub widget in Settings Logs card (#67) 2026-04-17 14:36:26 +00:00
importConfigTemplateService.ts feat: persist template selection and add update template button 2026-02-15 13:16:55 +00:00
importedFileService.ts feat(transactions): inline transfer icon + FK error message 2026-04-25 16:38:46 -04:00
importSourceService.ts fix: persist has_header for imports, fix orphan categories, add re-initialize 2026-02-12 11:54:33 +00:00
licenseService.ts feat: Maximus Account OAuth2 PKCE + machine activation + subscription check (#51, #53) 2026-04-10 14:18:51 -04:00
logService.test.ts feat: feedback hub widget in Settings Logs card (#67) 2026-04-17 14:36:26 +00:00
logService.ts feat: feedback hub widget in Settings Logs card (#67) 2026-04-17 14:36:26 +00:00
profileService.ts fix: address reviewer feedback (#54) 2026-04-09 15:46:27 -04:00
reportService.cartes.test.ts feat(reports/cartes): Mensuel/YTD toggle on KPI cards + user guide section (#102) 2026-04-19 09:49:21 -04:00
reportService.test.ts feat(reports/highlights): default reference month to previous month + YTD current year, user-changeable (#106) 2026-04-19 08:28:30 -04:00
reportService.ts feat(reports/cartes): Mensuel/YTD toggle on KPI cards + user guide section (#102) 2026-04-19 09:49:21 -04:00
transactionService.ts feat(transactions): inline transfer icon + FK error message 2026-04-25 16:38:46 -04:00
userPreferenceService.ts feat(prices): Settings revocation toggle for price_fetching_consent 2026-04-27 08:41:15 -04:00