feat(balance): refonte editeur — reducer holdings + dispatch account.kind #213

Closed
opened 2026-06-04 01:36:42 +00:00 by maximus · 0 comments
Owner

Refonte structurelle de useSnapshotEditor pour N holdings/compte + bascule de TOUT le dispatch sur account.kind (au lieu de category_kind). Findings critiques de la revue. Effort L.

Fichiers concernes

  • src/hooks/useSnapshotEditor.ts (reecriture)
  • src/components/balance/SnapshotLineRow.tsx (dispatch account.kind)
  • src/components/balance/AccountForm.tsx (gating account.kind)

Depends on

Criteres d acceptation

  • useSnapshotEditor : etat Record<accountId, Holding[]>, actions ADD/REMOVE/SET_HOLDING_FIELD, hydratation LOADED via listHoldingsBySnapshotLine
  • Tout le dispatch simple/detaille lit account.kind (plus category_kind) ; category.kind ne reste que le defaut suggere (seed) de l AccountForm
  • Pre-remplissage holdings (qty 0 exclus, book_cost reporte) via getHoldingsForLatestSnapshot
  • Un compte detailed sous categorie simple s affiche correctement (regression visee)
  • npm run build + npm test verts

Review caveats

  • TECH (rouge, RESOLU): reecriture du reducer = effort L, pas un Modifier incremental.
  • ARCH (rouge, RESOLU): migrer TOUS les sites de dispatch category_kind -> account.kind (SnapshotLineRow ~L68, useSnapshotEditor ~L282/L387, AccountForm ~L138).

Decisions prises ce soir

  • (spec) kind migre categorie -> compte (simple|detailed).

Spec source

spec-plan-bilan-detail-titres.md (+ spec-decisions-bilan-detail-titres.md)

Refonte structurelle de useSnapshotEditor pour N holdings/compte + bascule de TOUT le dispatch sur account.kind (au lieu de category_kind). Findings critiques de la revue. Effort L. ## Fichiers concernes - src/hooks/useSnapshotEditor.ts (reecriture) - src/components/balance/SnapshotLineRow.tsx (dispatch account.kind) - src/components/balance/AccountForm.tsx (gating account.kind) ## Depends on - #212 ## Criteres d acceptation - [ ] useSnapshotEditor : etat Record<accountId, Holding[]>, actions ADD/REMOVE/SET_HOLDING_FIELD, hydratation LOADED via listHoldingsBySnapshotLine - [ ] Tout le dispatch simple/detaille lit account.kind (plus category_kind) ; category.kind ne reste que le defaut suggere (seed) de l AccountForm - [ ] Pre-remplissage holdings (qty 0 exclus, book_cost reporte) via getHoldingsForLatestSnapshot - [ ] Un compte detailed sous categorie simple s affiche correctement (regression visee) - [ ] npm run build + npm test verts ## Review caveats - TECH (rouge, RESOLU): reecriture du reducer = effort L, pas un Modifier incremental. - ARCH (rouge, RESOLU): migrer TOUS les sites de dispatch category_kind -> account.kind (SnapshotLineRow ~L68, useSnapshotEditor ~L282/L387, AccountForm ~L138). ## Decisions prises ce soir - (spec) kind migre categorie -> compte (simple|detailed). ## Spec source spec-plan-bilan-detail-titres.md (+ spec-decisions-bilan-detail-titres.md)
maximus added this to the overnight-2026-06-05-bilan-detail-titres milestone 2026-06-04 01:36:42 +00:00
maximus added the
status:ready
type:feature
source:human
labels 2026-06-04 01:36:42 +00:00
maximus added
status:review
and removed
status:ready
labels 2026-06-06 17:30:21 +00:00
maximus added
status:approved
and removed
status:review
labels 2026-06-06 19:37:04 +00:00
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: maximus/Simpl-Resultat#213
No description provided.