chore(ci): drop redundant push trigger; add concurrency group #172

Merged

maximus merged 1 commit from issue-171-ci-drop-push-trigger into main

2026-04-29 01:17:31 +00:00

maximus commented

2026-04-29 00:50:54 +00:00

Owner

Summary

Drops the redundant push trigger from both CI workflows. PR #170 was running 4 jobs (rust+frontend × push+pull_request) instead of 2. Keeps only pull_request: branches: [main] and adds a concurrency group so force-pushes cancel obsolete runs instead of stacking.

Changes

.forgejo/workflows/check.yml — drop on.push, add concurrency group, refresh comment.
.github/workflows/check.yml — same change to keep the GitHub mirror in sync.

Trade-off

Branches pushed without an open PR no longer trigger CI. /fix-issue opens a PR right after pushing, so in practice the gap is seconds. Anyone who wants CI feedback before requesting review can open a draft PR.

Test plan

This very PR is the smoke test:

After this PR opens, exactly 2 jobs should appear (PR Check / rust (pull_request), PR Check / frontend (pull_request)) — not 4.
Both should be green (no application code touched).

Acceptance criteria from #171

Drop on.push block in .forgejo/workflows/check.yml
Add concurrency group with cancel-in-progress: true
Apply same change to .github/workflows/check.yml (mirror)
Verify on this PR that exactly 2 runs trigger (validated by reviewer when CI lands)

Fixes #171

## Summary Drops the redundant `push` trigger from both CI workflows. PR #170 was running 4 jobs (rust+frontend × push+pull_request) instead of 2. Keeps only `pull_request: branches: [main]` and adds a `concurrency` group so force-pushes cancel obsolete runs instead of stacking. ## Changes - `.forgejo/workflows/check.yml` — drop `on.push`, add `concurrency` group, refresh comment. - `.github/workflows/check.yml` — same change to keep the GitHub mirror in sync. ## Trade-off Branches pushed without an open PR no longer trigger CI. `/fix-issue` opens a PR right after pushing, so in practice the gap is seconds. Anyone who wants CI feedback before requesting review can open a draft PR. ## Test plan This very PR is the smoke test: - [ ] After this PR opens, exactly 2 jobs should appear (`PR Check / rust (pull_request)`, `PR Check / frontend (pull_request)`) — not 4. - [ ] Both should be green (no application code touched). ## Acceptance criteria from #171 - [x] Drop `on.push` block in `.forgejo/workflows/check.yml` - [x] Add `concurrency` group with `cancel-in-progress: true` - [x] Apply same change to `.github/workflows/check.yml` (mirror) - [ ] Verify on this PR that exactly 2 runs trigger (validated by reviewer when CI lands) Fixes #171

maximus added 1 commit 2026-04-29 00:50:55 +00:00

chore(ci): drop redundant push trigger; add concurrency group

PR Check / rust (pull_request) Successful in 22m29s

Details

PR Check / frontend (pull_request) Successful in 2m26s

Details

af36b51cf7

The `push` + `pull_request` combo doubled CI runs on every PR (visible
on #170 with 4 pending checks instead of 2). Drop `push`, keep
`pull_request: branches: [main]`.

Trade-off: branches pushed without an open PR no longer get CI
feedback. Open a draft PR if you want CI to run before requesting
review — `/fix-issue` always opens a PR right after pushing, so the
gap is essentially zero in practice.

Also adds a concurrency group `ci-${{ github.ref }}` with
cancel-in-progress so force-pushes cancel the previous run instead
of stacking.

Same change applied to .github/workflows/check.yml (GitHub mirror)
to keep the two configs in sync.

Fixes #171