From 88c3c04dea918e7491edd719a19abab993be8a7d Mon Sep 17 00:00:00 2001 From: le king fu Date: Mon, 27 Apr 2026 21:32:59 -0400 Subject: [PATCH] chore: untrack decisions-log.md (autopilot scratch from #166 merge) --- decisions-log.md | 26 -------------------------- 1 file changed, 26 deletions(-) delete mode 100644 decisions-log.md diff --git a/decisions-log.md b/decisions-log.md deleted file mode 100644 index 6750de7..0000000 --- a/decisions-log.md +++ /dev/null @@ -1,26 +0,0 @@ -# Decisions Log — /autopilot run of 2026-04-27 - -## Issue #156 — session cap budget policy (MEDIUM) - -The 100-request session cap is checked BEFORE rate-limit enforcement and in-flight -deduplication. Successful fetches increment the counter; failures (4xx, 5xx, network) -do NOT consume the budget. Rationale: a user who hits a bad symbol or an auth error -should not have their session budget drained by error conditions outside their control. -This is the most user-friendly interpretation of "hard 100/session cap" while still -protecting against runaway loops. - -## Issue #156 — __resetForTests helper exported from prices namespace (LOW) - -The `prices.__resetForTests()` helper is exported alongside `fetchPrice`. This avoids -the need for `vi.resetModules()` + dynamic import between tests, which is flakier and -slower. The helper is named with `__` prefix to signal test-only usage. Alternative -considered: module-level export — rejected because it would pollute the public API -surface of balance.service outside the prices namespace. - -## Issue #156 — rate-limit pacing test strategy (LOW) - -The pacing test verifies that setTimeout is called with a positive delay for the 2nd -and 3rd concurrent calls, rather than asserting exact wall-clock timestamps via -Date.now(). This is because vi.useFakeTimers() advances Date.now() via timer -advancement, not automatically between microtasks. The spy approach is more resilient -to vitest internals and fake-timer edge cases.