From 76fd8d376a52dff36b1ceb8d1347ae4a3cd98370 Mon Sep 17 00:00:00 2001 From: le king fu Date: Sat, 3 Oct 2026 19:23:43 -0400 Subject: [PATCH] refactor(onboarding): compute the load error message once (#351) Self-review tidy: `errorMessage(e)` was evaluated twice in `refresh`. Co-Authored-By: Claude Fable 5.1 --- src/hooks/useOnboardingChecklist.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/hooks/useOnboardingChecklist.ts b/src/hooks/useOnboardingChecklist.ts index b2f1eed..3c3205c 100644 --- a/src/hooks/useOnboardingChecklist.ts +++ b/src/hooks/useOnboardingChecklist.ts @@ -93,8 +93,9 @@ export function useOnboardingChecklist() { const snapshot = await getOnboardingCounters(); dispatch({ type: "LOAD_DONE", snapshot }); } catch (e) { - logError("Onboarding: failed to load checklist counters", errorMessage(e)); - dispatch({ type: "LOAD_ERROR", error: errorMessage(e) }); + const error = errorMessage(e); + logError("Onboarding: failed to load checklist counters", error); + dispatch({ type: "LOAD_ERROR", error }); } }, []);