maximus/Simpl-Resultat
1
0
Fork 0
Code Issues 19 Pull requests 8 Projects Releases 34 Packages Wiki Activity Actions

refactor(onboarding): name the checklist preference states after what they hold (#352)
All checks were successful
PR Check — Frontend / frontend (pull_request) Successful in 1m42s
Details

Browse source 
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
le king fu 2026-10-03 19:34:24 -04:00
parent a060f0e0e0
commit 3f3531392e
1 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/pages/settings/UsersSettingsPage.tsx
View file

@ -12,24 +12,25 @@ import {
} from "../../services/onboardingService"; } from "../../services/onboardingService";
import { logError } from "../../services/logService"; import { logError } from "../../services/logService";
// Re-show button of the getting-started checklist (#352). `hidden` = the // Getting-started checklist preference, for its re-show button (#352).
// preference was "1" at mount; `shown` = the button was clicked and the // `dismissed` = the preference was "1" at mount, the button is offered;
// preference removed, so a confirmation line replaces the button. // `restored` = the button was clicked and the preference removed, so a
type ChecklistButtonState = "unknown" | "visible" | "hidden" | "shown"; // confirmation line replaces it; `shown` = nothing to offer.
type ChecklistPreference = "unknown" | "shown" | "dismissed" | "restored";
export default function UsersSettingsPage() { export default function UsersSettingsPage() {
const { t } = useTranslation(); const { t } = useTranslation();
const [checklistButton, setChecklistButton] = useState<ChecklistButtonState>("unknown"); const [checklistPref, setChecklistPref] = useState<ChecklistPreference>("unknown");
useEffect(() => { useEffect(() => {
let cancelled = false; let cancelled = false;
(async () => { (async () => {
try { try {
const value = await getPreference(ONBOARDING_CHECKLIST_HIDDEN_KEY); const value = await getPreference(ONBOARDING_CHECKLIST_HIDDEN_KEY);
if (!cancelled) setChecklistButton(value === "1" ? "hidden" : "visible"); if (!cancelled) setChecklistPref(value === "1" ? "dismissed" : "shown");
} catch (e) { } catch (e) {
// Informational control: without the preference, keep it out of the way. // Informational control: without the preference, keep it out of the way.
if (!cancelled) setChecklistButton("visible"); if (!cancelled) setChecklistPref("shown");
logError("Settings: failed to read the checklist preference", e); logError("Settings: failed to read the checklist preference", e);
} }
})(); })();
@ -41,7 +42,7 @@ export default function UsersSettingsPage() {
const handleShowChecklist = async () => { const handleShowChecklist = async () => {
try { try {
await showChecklist(); await showChecklist();
setChecklistButton("shown"); setChecklistPref("restored");
} catch (e) { } catch (e) {
logError("Settings: failed to show the checklist", e); logError("Settings: failed to show the checklist", e);
} }
@ -77,11 +78,11 @@ export default function UsersSettingsPage() {
<h2 className="text-sm font-semibold uppercase tracking-wider text-[var(--muted-foreground)]"> <h2 className="text-sm font-semibold uppercase tracking-wider text-[var(--muted-foreground)]">
{t("settings.users.sections.userGuide")} {t("settings.users.sections.userGuide")}
</h2> </h2>
{(checklistButton === "hidden" || checklistButton === "shown") && ( {(checklistPref === "dismissed" || checklistPref === "restored") && (
<div className="flex flex-wrap items-center gap-3 rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 text-sm"> <div className="flex flex-wrap items-center gap-3 rounded-xl border border-[var(--border)] bg-[var(--card)] p-4 text-sm">
<ListChecks size={18} className="shrink-0 text-[var(--muted-foreground)]" aria-hidden="true" /> <ListChecks size={18} className="shrink-0 text-[var(--muted-foreground)]" aria-hidden="true" />
<span className="flex-1 min-w-[12rem]">{t("settings.users.onboarding.label")}</span> <span className="flex-1 min-w-[12rem]">{t("settings.users.onboarding.label")}</span>
{checklistButton === "hidden" ? ( {checklistPref === "dismissed" ? (
<button <button
type="button" type="button"
onClick={handleShowChecklist} onClick={handleShowChecklist}