maximus/Simpl-Resultat
1
0
Fork 0
Code Issues 5 Pull requests Projects Releases 23 Packages Wiki Activity Actions

fix(balance): exclude archived accounts from starter collisions (S4)

Browse source 
getStarterCollisions now filters `archived_at IS NULL` so a starter
account the user voluntarily archived no longer blocks re-creation
through the StarterAccountsModal. Matches the rest-of-codebase
convention (active = is_active=1 AND archived_at IS NULL).

Suggestion S4 from PR #185 review (#187).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
le king fu 2026-05-03 16:26:23 -04:00
parent fbd8be403a
commit 2eeac78b40
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/components/balance/StarterAccountsModal.test.tsx
View file

@ -73,6 +73,13 @@ describe("getStarterCollisions", () => {
expect(result.has("tfsa")).toBe(false); expect(result.has("tfsa")).toBe(false);
expect(result.has("cash")).toBe(false); // name "CELI" != "Compte chèque" expect(result.has("cash")).toBe(false); // name "CELI" != "Compte chèque"
}); });
it("excludes archived accounts via SQL filter", async () => {
mockSelect.mockResolvedValueOnce([]);
await getStarterCollisions();
const sql = mockSelect.mock.calls[0][0];
expect(sql).toMatch(/archived_at IS NULL/);
});
}); });
describe("proposeStarterAccounts", () => { describe("proposeStarterAccounts", () => {

3
src/services/balance.service.ts
View file

@ -487,7 +487,8 @@ export async function getStarterCollisions(): Promise<Set<string>> {
`SELECT c.key AS key, a.name AS account_name `SELECT c.key AS key, a.name AS account_name
FROM balance_accounts a FROM balance_accounts a
INNER JOIN balance_categories c ON c.id = a.balance_category_id INNER JOIN balance_categories c ON c.id = a.balance_category_id
WHERE c.key IN ('cash','tfsa','rrsp','other')` WHERE c.key IN ('cash','tfsa','rrsp','other')
AND a.archived_at IS NULL`
); );
const collisions = new Set<string>(); const collisions = new Set<string>();
for (const starter of STARTER_ACCOUNTS) { for (const starter of STARTER_ACCOUNTS) {